Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58234] Support negative duration #1923

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[MM-58234] Support negative duration #1923

merged 1 commit into from
Jul 5, 2024

Conversation

JulienTant
Copy link
Member

Summary

Add support for negative durations into the duration formatting

Ticket Link

https://mattermost.atlassian.net/browse/MM-58234

Checklist

  • Unit tests updated

@JulienTant JulienTant added 2: Dev Review Requires review by a core committer QA Deferred labels Jun 27, 2024
@JulienTant JulienTant requested a review from lindy65 June 27, 2024 16:28
lindy65
lindy65 approved these changes Jun 27, 2024
View reviewed changes
Copy link

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulienTant - I'll test this post merge 👍

rahimrahman
rahimrahman approved these changes Jul 2, 2024
View reviewed changes
Copy link

@rahimrahman rahimrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me observe while you work on this.

The only thing I would do differently is the naming of the variables such as absoluteValue vs localValue, and formattedString vs str for better readability. But those are small nit picks.

@JulienTant JulienTant merged commit a45555c into master Jul 5, 2024
15 checks passed
@JulienTant JulienTant deleted the MM-58234 branch July 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahimrahman rahimrahman rahimrahman approved these changes

@calebroseland calebroseland calebroseland approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer QA Deferred
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulienTant @rahimrahman @calebroseland @lindy65